can subprocess_join tell if the process failed?

[pthom]

Hello,

Thanks for this useful library! I encountered a problem when calling subprocess_join: it cannot detect whether the process failed.

The following lines taken from the code show the reason:

  if (out_return_code) {
    if (WIFEXITED(status)) {
      *out_return_code = WEXITSTATUS(status);
    } else {
      *out_return_code = 0  // process did not exit normally, but we return 0 as exit status, anyway (!)
    }
  }

Is there another way to check for process failures?

Thanks!

[sheredom]

Hey @pthom! Yeah that looks like a bug.

Do you have any small repro case for a process that doesn't exit 'normally'? I'm honestly not that sure how you can even get there (segfault or something?).

[sheredom]

Fixed by @pthom - thanks!