Closed windowsair closed 2 years ago
But it doesn't look like it meets the specification.... I'm not sure that's a good idea.
Yeah I'm torn about this - it makes the library behave differently depending on if you have a single arg or not. Seems bad to me on first instincts!
Yes, this approach may not be good. Perhaps we should focus on issues like #59.
The way libuv (and by extension Node.js) fixes this is by adding another option windowsVerbatimArgument
which will simply concatenate the arguments without escaping.
https://nodejs.org/api/child_process.html#child_processexecfilefile-args-options-callback
First of all, thank you for this project, it's the most convenient C/C++ library I've seen so far!
This question is out of my personal preference.
Sometimes I like to use a cmd like this:
And this is the current msvc implementation in the project:
Well, I didn't look closely at the code, but when I had only one command, I observed the wrong escape.
As mentioned above, this is likely to be a complex command line if there is only one command. It is better to follow the user's input and just take the command line without modifying it.
What do you think about this? Thanks!