search

sheredom / subprocess.h

🐜 single header process launching solution for C and C++
The Unlicense
1.1k stars 97 forks source link

posix_spawn does not build on Android & Emscripten (Wasm) #66

Closed aardappel closed 2 years ago

aardappel commented 2 years ago

The changes introduced here https://github.com/sheredom/subprocess.h/commit/de3cbecd06d5a631e74ec6e77d03ec466d861726 produce compilation errors on these two platforms: https://github.com/aardappel/lobster/actions/runs/2278815862

Now I am totally fine #ifdeffing support out for those 2 platforms, since it doesn't make any sense to spawn processes there anyway. But the curious thing is that the old fork code DID compile on those platforms.

So it is more of a question if you want to #ifdef it in your library for maximum modularity, or if you want users to #ifdef it :) I don't mind either way. Feel free to close if WillNotFix.

sheredom commented 2 years ago

I think I'd want users to #ifdef it - given that subprocess spawning doesn't work on those platforms anyway I don't see much of the point!