Closed cah4a closed 1 year ago
3. It seems that
resolve.conditions
doesn’t serve any purpose, so I’ve removed it.
There is literally a comment where it's explained why this condition is needed.
// plugin adds this condition automatically
Am I reading it wrong or it does tell nothing about why it's needed?
// plugin adds this condition automatically
Am I reading it wrong or it does tell nothing about why it's needed?
Sorry, I remembered it wrong. This condition is needed for libraries that define a custom exports
condition: https://reactnative.dev/blog/2023/06/21/package-exports-support#the-new-react-native-condition
Got you. It's required for third-party react-native libraries.
I've rolled back this change.
Thanks!
Hello @sheremet-va,
Could you please release a version with this change?
Hello @sheremet-va,
Could you please release a version with this change?
Released as 0.1.4
A huge thanks!
1) Currently, vitest automatically attempts to transpile react-native, which leads to errors due to its inability to understand flow syntax. To resolve this, it's necessary to add react-native to
server.deps.external
.2) Not all code was being transpiled as expected due to the lack of a
.ios.js
extension in thepirates.addHook
. And since .ios.js is a lookup extension, there’s no need to replace it within the code.3)
It seems thatresolve.conditions
doesn’t serve any purpose, so I’ve removed it.