Create individual cell instances instead of copying the pointer to a unique cell

sherjilozair / char-rnn-tensorflow

Multi-layer Recurrent Neural Networks (LSTM, RNN) for character-level language models in Python using Tensorflow

MIT License

2.64k stars 960 forks source link

Create individual cell instances instead of copying the pointer to a unique cell #60

Closed kevin-keraudren closed 7 years ago

kevin-keraudren commented 7 years ago

I explain the proposed fix in details here: https://github.com/tensorflow/tensorflow/pull/5599 and you can compare output of python train.py && python sample.py here: https://gist.github.com/kevin-keraudren/cbb948f06ac817d8efa5ed110b980fa9

Without the fix, I attain a train_loss of 1.305 while in reaches 1.295 with the fix. More importantly, the output of the network sounds slightly more like Shakespeare.

kevin-keraudren commented 7 years ago

False alarm, closing the issue.