search

sherjilozair / char-rnn-tensorflow

Multi-layer Recurrent Neural Networks (LSTM, RNN) for character-level language models in Python using Tensorflow
MIT License
2.64k stars 964 forks source link

Removed unnecessary line #99

Closed royaff0 closed 6 years ago

royaff0 commented 7 years ago

Removed unnecessary lines.

One of lines makes train op run twice on every batch, train op can be faster and train loss be smoother by remove it. And another affected TensorBoard graphs

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 92.692% when pulling 8cc1887225b8bf9f358e83ce82bbc3ff87e6dfb7 on RoyaAoki:master into 5029173fc6ad527545082abcaf6c267061825484 on sherjilozair:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 92.692% when pulling 8cc1887225b8bf9f358e83ce82bbc3ff87e6dfb7 on RoyaAoki:master into 5029173fc6ad527545082abcaf6c267061825484 on sherjilozair:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 92.692% when pulling 8cc1887225b8bf9f358e83ce82bbc3ff87e6dfb7 on RoyaAoki:master into 5029173fc6ad527545082abcaf6c267061825484 on sherjilozair:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.03%) to 92.692% when pulling 8cc1887225b8bf9f358e83ce82bbc3ff87e6dfb7 on RoyaAoki:master into 5029173fc6ad527545082abcaf6c267061825484 on sherjilozair:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.06%) to 92.664% when pulling 523c5562b490068a7e92d61fc89c2336a68dda7b on RoyaAoki:master into 5029173fc6ad527545082abcaf6c267061825484 on sherjilozair:master.

GaoleMeng commented 6 years ago

Hey, I encounter the same "Coverage decreased (-0.06%) to 92.664%" when trying to make a pull request when revise other unnecessary lines. I think this is a weird check, maybe a threshold should be set like 1 percent or so, hmm...

sherjilozair commented 6 years ago

Thanks for this much needed fix @GaoleMeng !