sherjilozair / dqn

Basic DQN implementation
MIT License
217 stars 72 forks source link

Cropping won't work for all environments #7

Closed claymcleod closed 8 months ago

claymcleod commented 8 years ago

Hey @sherjilozair/everyone,

Just letting you know, this almost certainly won't work for any arbitrary game — at least, correctly — in its current form. The problem is the cropping: cropping a static 84x84 window in the center will miss a lot of important information.

Take for instance SpaceInvaders-v0. This is what the convolutional network sees: figure_1. Where is the ship that we control? It is cropped off the bottom of the screen. Thus, this information can't be contained within the network.

I appreciate that this is just a simple implementation, but it's worth noting that a complete solution would have hand picked regions over which to crop for each game (unfortunately).