Closed sherlock-admin closed 1 year ago
lemonmon
medium
Boosted3TokenAuraVault::_depositFromNotional
One can enter the vault within the settlement window
According to the comment,
// Entering the vault is not allowed within the settlement window
However, there is no code to enforce the comment
https://github.com/sherlock-audit/2022-09-notional/blob/main/leveraged-vaults/contracts/vaults/Boosted3TokenAuraVault.sol#L64-L81
Manual Review
Add the check for the settlement window
lemonmon
medium
Boosted3TokenAuraVault::_depositFromNotional
lacks the check for the settlement windowSummary
One can enter the vault within the settlement window
Vulnerability Detail
According to the comment,
However, there is no code to enforce the comment
Impact
One can enter the vault within the settlement window
Code Snippet
https://github.com/sherlock-audit/2022-09-notional/blob/main/leveraged-vaults/contracts/vaults/Boosted3TokenAuraVault.sol#L64-L81
Tool used
Manual Review
Recommendation
Add the check for the settlement window