Variables for strategist fees are basically unused.
Vulnerability Detail
strategistFeeNumerator and strategistFeeDenominator are declared and initialized but never used meaningfully leaving questions about what were the intentions and why are they present in the codebase. Also function getStrategistFee becomes misleading then for an external reader.
Impact
It is not entirely clear to me if these variables were left from the previous version of the codebase (refactoring) or if a strategist fee is not charged and it is a bug in the codebase. I've assigned a severity of low to let you know about this issue and make an appropriate decision.
HonorLt
low
Strategist fee is not used
Summary
Variables for strategist fees are basically unused.
Vulnerability Detail
strategistFeeNumerator
andstrategistFeeDenominator
are declared and initialized but never used meaningfully leaving questions about what were the intentions and why are they present in the codebase. Also functiongetStrategistFee
becomes misleading then for an external reader.Impact
It is not entirely clear to me if these variables were left from the previous version of the codebase (refactoring) or if a strategist fee is not charged and it is a bug in the codebase. I've assigned a severity of low to let you know about this issue and make an appropriate decision.
Code Snippet
https://github.com/sherlock-audit/2022-10-astaria/blob/main/src/AstariaRouter.sol#L68-L69
https://github.com/sherlock-audit/2022-10-astaria/blob/main/src/AstariaRouter.sol#L110-L111
https://github.com/sherlock-audit/2022-10-astaria/blob/main/src/AstariaRouter.sol#L428-L435
Tool used
Manual Review
Recommendation
Depending on intentions, charge the strategist fees or remove them from the codebase.