Use of deprecated function will cause incompatibility and indefinite reverts of essential marketplace functions for future pools.
Vulnerability Detail
According to Yieldspace code documentation the function base to retrieve the base token of a pool has already been deprecated and is prone to be removed at anytime.
It is still used in the following market place functions: buyPrincipalToken, sellUnderlying, mint and mintWithUnderlying
Impact
All the functions outlined in #Vulnerability Detail will stop working if used in conjunction with a pool whose base function has been removed.
Code Snippet
None
Tool used
Manual Review
Recommendation
Use the function baseToken instead which returns an IERC20Like that also conforms to IERC20, so there will be no compatibility issues.
minhtrng
unlabeled
Deprecation of
basefunctionSummary
Use of deprecated function will cause incompatibility and indefinite reverts of essential marketplace functions for future pools.
Vulnerability Detail
According to Yieldspace code documentation the function
baseto retrieve the base token of a pool has already been deprecated and is prone to be removed at anytime.It is still used in the following market place functions:
buyPrincipalToken,sellUnderlying,mintandmintWithUnderlyingImpact
All the functions outlined in #Vulnerability Detail will stop working if used in conjunction with a pool whose
basefunction has been removed.Code Snippet
None
Tool used
Manual Review
Recommendation
Use the function
baseTokeninstead which returns anIERC20Likethat also conforms toIERC20, so there will be no compatibility issues.