Closed github-actions[bot] closed 1 year ago
validDao
informational
Boolean variates can be directly used in conditional statement. Remove its comparision to true or false would save a little bit gas.
https://github.com/sherlock-audit/2022-11-dodo/blob/main/contracts/SmartRoute/DODORouteProxy.sol#L207 if (success == false) { assembly { revert(add(result,32),mload(result)) } }
Informational
See Vulnerability Detail
Manual Review
rewrite if (success == false) to if(!success)
validDao
informational
Not necessary to write boolean equality
Summary
Boolean variates can be directly used in conditional statement. Remove its comparision to true or false would save a little bit gas.
Vulnerability Detail
https://github.com/sherlock-audit/2022-11-dodo/blob/main/contracts/SmartRoute/DODORouteProxy.sol#L207 if (success == false) { assembly { revert(add(result,32),mload(result)) } }
Impact
Informational
Code Snippet
See Vulnerability Detail
Tool used
Manual Review
Recommendation
rewrite if (success == false) to if(!success)