search

sherlock-audit / 2022-11-nounsdao-judging

4 stars 0 forks source link

pzeus - Reentrancy exploit #26

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

pzeus

high

Reentrancy exploit

Summary

Potential of reentrancy attack

Vulnerability Detail

There is an external contract call which might end up with an reentrancy exploit since we do not know the implementation of the ERC token

Impact

Might end up with stealing funds from the protocol

Code Snippet

https://github.com/sherlock-audit/2022-11-nounsdao/blob/main/src/Stream.sol#L237

Tool used

Manual Review

Recommendation

Usage of OpenZeppelin's nonReentrant guard or some other custom implementation preventing this