sherlock-audit / 2022-11-nounsdao-judging

4 stars 0 forks source link

reassor - Missing event emitting for function `Stream.rescueERC20` #53

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

reassor

medium

Missing event emitting for function Stream.rescueERC20

Summary

Contract Stream emits events for functions such as withdraw and cancel. The issue is that function rescueERC20 is missing such an event emitting.

Vulnerability Detail

Function rescueERC20 of Stream contract is missing emitting of event such as event RescueERC20(token, amount).

Impact

Off-chain applications that monitor protocol will be not able to monitor withdrawal of arbitrary ERC20 tokens "rescuing" that have been transferred to the contract.

Code Snippet

https://github.com/sherlock-audit/2022-11-nounsdao/blob/main/src/Stream.sol#L268-L272

Tool used

Manual Review

Recommendation

It is recommended to add event emitting to rescueERC20 function of Stream contract.