sherlock-audit / 2023-01-derby-judging

4 stars 1 forks source link

ff - `connext` address is immutable #378

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

ff

medium

connext address is immutable

Summary

Connext address used by the XProvider to make all cross chain messaging / calls is immutable.

Vulnerability Detail

The connext contract is used for all cross chain messaging / transfer and cannot be changed.

Impact

If the Connext team updates their contract for security reasons, the Derby Protocol cannot be update it.

Code Snippet

  address public immutable connext;

Tool used

Manual Review

Recommendation

Remove the immutable attribute to the connext variable and add a setter accessible for guardian / dao users.