sherlock-audit / 2023-01-derby-judging

4 stars 1 forks source link

josephdara - vault.sol #419

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

josephdara

medium

vault.sol

Summary

Medium Minimum pull cannot be updated in Vault.sol: Minimumpull should have a function to increase or decrease it's value depending on market conditions but it is hard coded in the constructor. I suggest a function


    minimumPull = _minimumPull
}```

Else 
It's declaration should be set to Immutable:

```  uint256 public immutable minimumPull;

## Vulnerability Detail

## Impact

## Code Snippet

## Tool used

Manual Review

## Recommendation