Closed github-actions[bot] closed 1 year ago
cergyk
low
Extra onlyOtherBridge modifier on finalizeERC20Withdrawal
onlyOtherBridge
finalizeERC20Withdrawal
the onlyOtherBridge modifier found here: https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol#L122
is unused since finalizeBridgeERC20 which is called in the function has it as well
finalizeBridgeERC20
Gas overconsumption
Manual Review
Remove this modifier here
cergyk
low
Extra onlyOtherBridge modifier on finalizeERC20Withdrawal in L1StandardBridge.sol
Summary
Extra
onlyOtherBridgemodifier onfinalizeERC20WithdrawalVulnerability Detail
the
onlyOtherBridgemodifier found here: https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L1/L1StandardBridge.sol#L122is unused since
finalizeBridgeERC20which is called in the function has it as wellImpact
Gas overconsumption
Code Snippet
Tool used
Manual Review
Recommendation
Remove this modifier here