Chom - L1ERC721Bridge is not implementing ERC721Receiver, although it is holding ERC721 tokens which is an anti-pattern.

[github-actions[bot]]

Chom

low

L1ERC721Bridge is not implementing ERC721Receiver, although it is holding ERC721 tokens which is an anti-pattern.

Summary

L1ERC721Bridge is not implementing ERC721Receiver, although it is holding ERC721 tokens which is an anti-pattern.

Vulnerability Detail

L1ERC721Bridge is not implementing ERC721Receive but holding ERC721 tokens.

Impact

This is an anti-pattern that doesn't follow the desired standard.

Code Snippet

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/L1/L1ERC721Bridge.sol#L1-L15

https://github.com/sherlock-audit/2023-01-optimism/blob/main/optimism/packages/contracts-bedrock/contracts/universal/ERC721Bridge.sol#L1-L11

Tool used

Manual Review

Recommendation

Implement ERC721Receiver on abstract contract ERC721Bridge to follow the standard