sherlock-audit / 2023-01-uxd-judging

3 stars 1 forks source link

hl_ - Users able to deposit, but unable to redeem quoteToken #307

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

hl_

medium

Users able to deposit, but unable to redeem quoteToken

Summary

Users are able to deposit, but unable to redeem quoteToken (i.e. virtual USD token).

Vulnerability Detail

In PerpDepository.sol, user is able to deposit quoteToken via the deposit function under specific circumstances. However, redemption of quoteToken is disabled in the redeem function.

Impact

User unable to redeem quoteToken deposited.

Code Snippet

https://github.com/sherlock-audit/2023-01-uxd/blob/main/contracts/integrations/perp/PerpDepository.sol#L272-L273

Tool used

Manual Review

Recommendation

Allow users to redeem quoteToken deposited, or disallow the deposit of quoteToken.

Duplicate of #165