search

sherlock-audit / 2023-01-uxd-judging

3 stars 1 forks source link

joestakey - `_redeem` should not revert for de-whitelisted assets #437

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

joestakey

medium

_redeem should not revert for de-whitelisted assets

Summary

If an asset is whitelisted, then removed from the whitelist, users will be unable to redeem their UXD

Vulnerability Detail

In _redeem(), there is a check that the asset to be received is whitelisted.

This means if users have deposited an asset, which is then removed from the whitelist, they are unable to redeem their UXD.

Impact

Some users will be unable to redeem

Code Snippet

https://github.com/sherlock-audit/2023-01-uxd/blob/main/contracts/core/UXDController.sol#L312-L318

Tool used

Manual Review

Recommendation

Remove this check from _redeem.

Duplicate of #385