sherlock-audit / 2023-01-uxd-judging

3 stars 1 forks source link

Qeew - Rebalancing positive PnL disabled #446

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Qeew

unlabeled

Rebalancing positive PnL disabled

Summary

Vulnerability Detail

https://github.com/sherlock-audit/2023-01-uxd/blob/main/contracts/integrations/perp/PerpDepository.sol#L530

Impact

The circulating supply of UXD will not be adjusted to match the delta-neutral position size. This can lead to an imbalance between the assets held by the contract and the assets held by its users, which can impact the stability of the system.

Code Snippet

https://github.com/sherlock-audit/2023-01-uxd/blob/main/contracts/integrations/perp/PerpDepository.sol#L530

Tool used

Manual Review

Recommendation

Admin acknowledge some kind of bugs with the Rebalancing positive PnL. It's better not to used them at all