sherlock-audit / 2023-02-blueberry-judging

12 stars 5 forks source link

Avci - everyone CAN Trigger interest accrual for banks and utokens #347

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

Avci

high

everyone CAN Trigger interest accrual for banks and utokens

Summary

everyone CAN Trigger interest accrual for banks and utokens

Vulnerability Detail

Lack of access control in BlueBerryBank.sol#accrue() anyone can do it in any moment they want

Impact

will cause unwanted accrual in interests and in false risky timing for certain utokens which is not acceptable

Code Snippet

   function accrue(address token) public override {
        Bank storage bank = banks[token];
        if (!bank.isListed) revert BANK_NOT_LISTED(token);
        bank.totalDebt = ICErc20(bank.cToken).borrowBalanceCurrent(
            address(this)
        );
    }

https://github.com/sherlock-audit/2023-02-blueberry/blob/main/contracts/BlueBerryBank.sol#L251

Tool used

Manual Review

Recommendation