sherlock-audit / 2023-02-fair-funding-judging

1 stars 0 forks source link

ck - NFTs can get stuck in contracts that don't support ERC-721 #101

Closed github-actions[bot] closed 1 year ago

github-actions[bot] commented 1 year ago

ck

medium

NFTs can get stuck in contracts that don't support ERC-721

Summary

NFTs can get stuck in contracts that don't support ERC-721

Vulnerability Detail

If the NFT is minted to a contract that doesn't support ERC-721, it will be frozen in the contract. This is because of the use of mint instead of safemint

Impact

Bidders would lose their NFTs

Code Snippet

https://github.com/sherlock-audit/2023-02-fair-funding/blob/main/fair-funding/contracts/AuctionHouse.vy#L208

Tool used

Manual Review

Recommendation

Use safemint instead of mint to check received address support for ERC721 implementation.

Duplicate of #14