The variable "HATS" which occurs in MultiHatsSignerGate.sol twice and in HatsSignerGate.sol once seems to be defined nowhere.
Vulnerability Detail
Honestly I'm running out of time now, because the contest will end in a few minutes. But I’ve sincerely checked multiple times. There’s no definition of "HATS" to be found anywhere within the project. I spontaneously believe "HATS" could be a struct.
My apologies in advance if I might have overlooked something.
As said, I’m running out of time. So I have no time left to figure out the concrete impact. But I thought I’ll report it nevertheless. I’ll label it as medium severity, though it could easily be a high.
Code Snippet
Tool used
Manual Review
Recommendation
Define the variable. And figure out why all of your tests passed nevertheless.
armathor
medium
"HATS" variable defined nowhere
Summary
The variable "HATS" which occurs in MultiHatsSignerGate.sol twice and in HatsSignerGate.sol once seems to be defined nowhere.
Vulnerability Detail
Honestly I'm running out of time now, because the contest will end in a few minutes. But I’ve sincerely checked multiple times. There’s no definition of "HATS" to be found anywhere within the project. I spontaneously believe "HATS" could be a struct.
My apologies in advance if I might have overlooked something.
occurrence of "HATS" : https://github.com/Hats-Protocol/hats-zodiac/blob/9455cc0957762f5dbbd8e62063d970199109b977/src/HatsSignerGate.sol#L76 https://github.com/Hats-Protocol/hats-zodiac/blob/9455cc0957762f5dbbd8e62063d970199109b977/src/MultiHatsSignerGate.sol#L57 https://github.com/Hats-Protocol/hats-zodiac/blob/9455cc0957762f5dbbd8e62063d970199109b977/src/MultiHatsSignerGate.sol#L89
Impact
As said, I’m running out of time. So I have no time left to figure out the concrete impact. But I thought I’ll report it nevertheless. I’ll label it as medium severity, though it could easily be a high.
Code Snippet
Tool used
Manual Review
Recommendation
Define the variable. And figure out why all of your tests passed nevertheless.