Closed sherlock-admin closed 1 year ago
There were outdated comments in the code which are fixed in https://github.com/ajna-finance/ecosystem-coordination/pull/119. We consider this a QA issue though with zero risk.
Agree with sponsor, this should be Informational/low because it has no real impact
josephdara
medium
Early vote cutoff
Summary
In
GrantFund.sol
the function propose does not follow it's specification. New proposals cannot be added immediately after the Screening Period which filters out the top 10 projects to be Funded However the code and comments conflictVulnerability Detail
We see that the
block.number
is compared against the currentDistribution startBlock.This calculates 73 days from distribution not the 80 days from the startBlock. 80 days signify the end of screening and funding votes
Impact
https://github.com/sherlock-audit/2023-04-ajna/blob/main/ajna-grants/src/grants/base/Storage.sol#L38-L43 https://github.com/sherlock-audit/2023-04-ajna/blob/main/ajna-grants/src/grants/GrantFund.sol#L134-L143 https://github.com/sherlock-audit/2023-04-ajna/blob/main/ajna-grants/src/grants/GrantFund.sol#L309-L313
Code Snippet
Tool used
Manual Review
Recommendation
Check and update code if it is 80 days, or update comments if it is 73 days