Closed sherlock-admin closed 1 year ago
PawelK
medium
deadline
swap
No deadline parameter in swap function
Swap function doesn't contain a deadline. The transaction can be stuck in mempool, and can be executed when the price won't be favorable for the user.
Financial loss due to receiving execution of the transaction in a time not controlled by the user
// deadline parameter missing function swap(address tokenIn, address tokenOut, AmountType amountType, uint256 amount)
Manual Review
Add deadline parameter to swap function
Duplicate of #88
PawelK
medium
No
deadline
inswap
functionSummary
No deadline parameter in
swap
functionVulnerability Detail
Swap function doesn't contain a deadline. The transaction can be stuck in mempool, and can be executed when the price won't be favorable for the user.
Impact
Financial loss due to receiving execution of the transaction in a time not controlled by the user
Code Snippet
Tool used
Manual Review
Recommendation
Add deadline parameter to
swap
functionDuplicate of #88