search

sherlock-audit / 2023-05-ironbank-judging

2 stars 2 forks source link

zklim - interestRateModelAddress is not checked during listMarket() in MarketConfigurator.sol #495

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

zklim

medium

interestRateModelAddress is not checked during listMarket() in MarketConfigurator.sol

Summary

No check on interestRateModelAddress to confirm it is not 0 address.

Vulnerability Detail

If admin accidently input 0 address for interestRateModelAddress while setting config using listMarket function, interest rate will not be working correctly and affect everything that rely on interestRateModelAddress.

Impact

Everything that rely on interestRateModelAddress will not work properly.

Code Snippet

https://github.com/sherlock-audit/2023-05-ironbank/blob/main/ib-v2/src/protocol/pool/MarketConfigurator.sol#L502

Tool used

Manual review.

Recommendation

Add check such as require(interestRateModelAddress != address(0)) to avoid possible vulnability.