twcctop - BuyOrderIssuer.sol#_fillBuyOrder doesn't transfer `receivedAmount`

[sherlock-admin]

twcctop

high

BuyOrderIssuer.sol#_fillBuyOrder doesn't transfer receivedAmount

Summary

BuyOrderIssuer.sol#_fillBuyOrder doesn't transfer receivedAmount, making the contract can not receive the receivedAmount token.

Vulnerability Detail

BuyOrderIssuer.sol#_fillBuyOrder should transfer receivedAmount to this contract, compare to SellOrderProcessor.sol#_fillOrderAccounting,

IERC20(orderRequest.paymentToken).safeTransferFrom(msg.sender, address(this), receivedAmount);

BuyOrderIssuer lack of related logic

Impact

BuyOrderIssuer can not receive receivedAmount token.

Code Snippet

https://github.com/sherlock-audit/2023-06-dinari/blob/main/sbt-contracts/src/issuer/BuyOrderIssuer.sol#L161-L189

Tool used

Manual Review

Recommendation

add transfer logic