search

sherlock-audit / 2023-06-symmetrical-judging

5 stars 4 forks source link

simon135 - since we dont pop of `PartyAPendingQuotes` from the array The user wont be able to to use the protocol again #326

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

simon135

medium

since we dont pop of PartyAPendingQuotes from the array The user wont be able to to use the protocol again

Summary

we delete PartyA pending Quotes but we don't pop them off as we do in PartyB liquidations and if PartyA fills up their Pending they wont be able to make more positions

Vulnerability Detail

https://github.com/sherlock-audit/2023-06-symmetrical/blob/main/symmio-core/contracts/facets/liquidation/LiquidationFacetImpl.sol#L123 Its very simple to the last issue just pop it off the array so the limit for Positions doesn't dos the user from using the protocol even though all the positions are liquidated

Impact

Dos for users when they should be able to use the protocol as if they are a new user

Code Snippet

Tool used

Forge Manual Review

Recommendation

add popping off the array but for PendingQuotes