search

sherlock-audit / 2023-07-perennial-judging

2 stars 1 forks source link

tvdung94 - Multi invoker does not allow users to liquidate a position without liquidation fee #115

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

tvdung94

medium

Multi invoker does not allow users to liquidate a position without liquidation fee

Summary

Multi invoker does not allow users to liquidate a position without liquidation fee.

Vulnerability Detail

As stated in updated mechanism document, now users have a option to liquidate a position without liquidation fee (value = 0). However, there is no such option when users issue liquidation command via batch command (multi invoker).

Impact

Users who wish to liquidate their own positions to preserve their balance will have to deposit again, paying more gas and settlement fee.

Code Snippet

https://github.com/sherlock-audit/2023-07-perennial/blob/main/perennial-v2/packages/perennial-extensions/contracts/MultiInvoker.sol#L221-L233

Tool used

Manual Review

Recommendation

Implement an additional parameter for liquidation fee as input.

sherlock-admin commented 1 year ago

2 comment(s) were left on this issue during the judging contest.

141345 commented:

l

panprog commented:

low (invalid) because of low impact