sherlock-audit / 2023-07-perennial-judging

2 stars 1 forks source link

WATCHPUG - `claimAssets` should not pay for a `settlementFee` #155

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

WATCHPUG

medium

`claimAssets` should not pay for a `settlementFee`

Summary

Vulnerability Detail

A fair share of the global settlementFee was paid for when opening and closing positions.

claimAssets does not incur any settlementFee on the market side.

Impact

Code Snippet

https://github.com/sherlock-audit/2023-07-perennial/blob/main/perennial-v2/packages/perennial-vault/contracts/Vault.sol#L286-L297

Tool used

Manual Review

Recommendation

Do not charge the settlementFee for claimAssets.

sherlock-admin commented 1 year ago

2 comment(s) were left on this issue during the judging contest.

141345 commented:

x

panprog commented:

invalid because its design choice