search

sherlock-audit / 2023-09-Gitcoin-judging

11 stars 7 forks source link

0xG0P1 - There is no `recieve/fallback` function implemented in `registry.sol` #974

Closed sherlock-admin closed 11 months ago

sherlock-admin commented 11 months ago

0xG0P1

medium

There is no recieve/fallback function implemented in registry.sol

regestry does not have any receive/fallback functions to receive ETH

Vulnerability Detail

recoverFunds function can transfer erc20 tokens and Native tokens to recipient but the registry.sol is not implementing any receive function to receive ETH. So it is impossible to send eth to the contract

Impact

Can't send Native tokens

Code Snippet

https://github.com/sherlock-audit/2023-09-Gitcoin/blob/main/allo-v2/contracts/core/Registry.sol#L387

Tool used

Manual Review

Recommendation

Implement receive/fallback function

sherlock-admin commented 11 months ago

1 comment(s) were left on this issue during the judging contest.

n33k commented:

invalid