John_Femi - Multiple places of unbounded loops

[sherlock-admin2]

John_Femi

medium

Multiple places of unbounded loops

There are multiple instances of unbounded loops

Vulnerability Detail

There are multiple instances of unbounded loops in the Allo and Registry contract, which could cause gas issues based on gas limit or DOS

Impact

High cost of usage, Reverted calls with external calls state changed

Code Snippet

https://github.com/sherlock-audit/2023-09-Gitcoin/blob/main/allo-v2/contracts/core/Registry.sol#L150

Tool used

Manual Review

Recommendation

Add checks for length of input before looping and add a max value of data to be looped at a time

[sherlock-admin]

1 comment(s) were left on this issue during the judging contest.

n33k commented:

invalid