search

sherlock-audit / 2023-09-perennial-judging

0 stars 0 forks source link

[Perennial Self Review] Incorrect price used during liquidation calculation #59

Open arjun-io opened 1 year ago

arjun-io commented 1 year ago

Fixed by https://github.com/equilibria-xyz/perennial-v2/pull/108

panprog commented 1 year ago

Fixed but when combined with #9, the liquidation will revert due to the fix (#9 will make oracle.latest().price = 0 and this will be used by the fix, while the correct Market process will use the latest valid oracle price in this case). The probability of this situation is very low, but still possible.

kbrizzle commented 1 year ago

Noted: we made this intentional decision since liquidations are generally predicated on posting a valid non-requested price anyways.

jacksanford1 commented 1 year ago

Based on @kbrizzle's comment, Sherlock will consider this issue as acknowledged due to a very low but still possible potential for reverting.