Fees unclaimed by a soon-to-be courier will become stuck

Summary

Unclaimed rewards of users, who become couriers will get permanently stuck

Vulnerability Detail

Users can become couriers by invoking enrollCourier() and earn a percentage of shares from referred users.

The problem stems from these users' fees not being explicitly claimed upon becoming couriers. If a user has unclaimed fees and becomes a courier, those fees will become permanently locked since couriers are not permitted to claim rewards.

function claimRewards(Lender[] calldata lenders, address beneficiary) external returns (uint256 earned) {
    require(!isCourier[msg.sender]);

    // ... 
}

Impact

Unclaimed fees of users who become couriers will get permanently stuck.

Code Snippet

https://github.com/sherlock-audit/2023-10-aloe/blob/main/aloe-ii/core/src/Factory.sol#L231

https://github.com/sherlock-audit/2023-10-aloe/blob/main/aloe-ii/core/src/Factory.sol#L254-L266

Tool used

Manual Review

Recommendation

Consider explicitly claiming their fees before making them a courier.

Duplicate of #134

sherlock-audit / 2023-10-aloe-judging

OxZ00mer - Fees unclaimed by a soon-to-be courier will become stuck #118