search

sherlock-audit / 2023-10-looksrare-judging

6 stars 6 forks source link

bareli - Didnot check ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD_MINUS_ONE. #100

Closed sherlock-admin closed 1 year ago

sherlock-admin commented 1 year ago

bareli

false

Didnot check ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD_MINUS_ONE.

Summary

Vulnerability Detail

Impact

Code Snippet

Tool used

Manual Review

Recommendation

ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD_MINUS_ONE = ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD.unsafeSubtract(1); HEAL_PROBABILITY_MINUEND = ((ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD 99 - 80) PROBABILITY_PRECISION) / ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD_MINUS_ONE;

ROUNDS_TO_BE_WOUNDED_BEFORE_DEAD_MINUS_ONE is never checked it can be 0. so it can be reverted.

https://github.com/sherlock-audit/2023-10-looksrare/blob/main/contracts-infiltration/contracts/Infiltration.sol#L381