search

sherlock-audit / 2023-10-looksrare-judging

6 stars 6 forks source link

Zims - The input agentIds is never checked #103

Closed sherlock-admin2 closed 1 year ago

sherlock-admin2 commented 1 year ago

Zims

medium

The input agentIds is never checked

Summary In InfiltrationPeriphery.sol the value of agentIds is never checked. Vulnerability Detail

Impact As it is a part of public and user controlled input you will want to check that the data is as expected to avoid unexpected issues.

Code Snippet https://github.com/sherlock-audit/2023-10-looksrare/blob/main/contracts-infiltration/contracts/InfiltrationPeriphery.sol#L45C38-L56

Tool used Manual Review

Recommendation some require() statements that make sure the data validity

nevillehuang commented 1 year ago

Invalid according to sherlock guidelines

User input validation: User input validation to prevent user mistakes is not considered a valid issue. However, if a user input could result in a major protocol malfunction or significant loss of funds could be a valid high. Example(Valid)