search

sherlock-audit / 2023-10-real-wagmi-judging

16 stars 14 forks source link

phenom - Loss of precision in divisions #164

Closed sherlock-admin2 closed 1 year ago

sherlock-admin2 commented 1 year ago

phenom

medium

Loss of precision in divisions

[L-3] Loss of precision in divisions

Impact:

Division by large numbers may result in the result being zero, due to Solidity not supporting fractions. Consider requiring a minimum amount for the numerator to ensure that it is always larger than the denominator.

Instances (1):

File: LiqBorrowingMan/LiquidityBorrowingManager.sol

971:         uint256 platformFees = (fees * platformFeesBP) / Constants.BP;
sherlock-admin2 commented 1 year ago

1 comment(s) were left on this issue during the judging contest.

tsvetanovv commented:

Invalid. Everything is as it should be