search

sherlock-audit / 2023-11-covalent-judging

3 stars 2 forks source link

Atharv - `BlockSpecimenProofChain.sol::finalizeSpecimenSession` should be called automatically by oracle, else noone will receive the rewards for the work. #119

Closed sherlock-admin2 closed 8 months ago

sherlock-admin2 commented 8 months ago

Atharv

high

BlockSpecimenProofChain.sol::finalizeSpecimenSession should be called automatically by oracle, else noone will receive the rewards for the work.

Summary

BlockSpecimenProofChain.sol::finalizeSpecimenSession should be called automatically by oracle. If no one called the function with correct data then quorum will never be achieved even with majority

Vulnerability Detail

If BlockSpecimenProofChain.sol::finalizeSpecimenSession function is not called by anyone with correct data then quorum will not be finalized and no one will receive their rewards for their work.

Impact

High

Code Snippet

Code

Tool used

Manual Review

Recommendation

Use Chainlink Automation tool which will call this function periodically hence everyone will get rewards for their POW

sherlock-admin2 commented 8 months ago

1 comment(s) were left on this issue during the judging contest.

takarez commented:

invalid

nevillehuang commented 8 months ago

Invalid, design suggestion and speculation on off-chain mechanisms.