search

sherlock-audit / 2023-11-covalent-judging

3 stars 2 forks source link

Atharv - If the seconds per Block changes for any of the chain then noone will able to submit blockspecimen proof. #123

Closed sherlock-admin2 closed 7 months ago

sherlock-admin2 commented 7 months ago

Atharv

medium

If the seconds per Block changes for any of the chain then noone will able to submit blockspecimen proof.

Summary

If the seconds per Block changes for any of the chain then noone will able to submit blockspecimen proof. as it will not pass this require statement and hence DOS.

Vulnerability Detail

As how protocol is calculating the currentBlock on target chain if the seconds per Block changes in any of the chain result in DOS. If seconds per Block in increased in one chain

require(lowerBound <= blockHeight && blockHeight <= currentBlockOnTargetChain + cd.allowedThreshold, "Block height is out of bounds for live sync");

We will get "lock height is out of bounds for live sync" error.

Impact

Medium

Code Snippet

Code

Tool used

Manual Review

Recommendation

sherlock-admin2 commented 7 months ago

1 comment(s) were left on this issue during the judging contest.

takarez commented:

invalid

nevillehuang commented 6 months ago

Invalid, this can always be adjusted by governor as seen here