nevillehuang
commented
6 months ago Invalid, modifiers in place and defined by inherited contract Kernel.sol as seen here where the abstract contract Module is inherited.
Closed sherlock-admin closed 6 months ago
nevillehuang
commented
6 months ago Invalid, modifiers in place and defined by inherited contract Kernel.sol as seen here where the abstract contract Module is inherited.
bareli
medium
Not implemented permissioned modifier
Summary
The contract uses a permissioned access control model, which is good for restricting sensitive operations. However, the actual implementation of the permissioned modifier is not shown, so it's important to ensure that it's secure and correctly manages permissions.
Vulnerability Detail
We have implemented a permissioned modifier at 6 different function but they have not define it.
Impact
permissioned will not be implemented.
Code Snippet
https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L312 https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L354 https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L418 https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L453 https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L525 https://github.com/sherlock-audit/2023-11-olympus/blob/main/bophades/src/modules/PRICE/OlympusPrice.v2.sol#L606
Tool used
Manual Review
Recommendation
Define the permissioned modifier.