search

sherlock-audit / 2023-12-dodo-gsp-judging

6 stars 5 forks source link

fibonacci - GSP contract does not implement IGSP Interface #124

Closed sherlock-admin closed 9 months ago

sherlock-admin commented 9 months ago

fibonacci

medium

GSP contract does not implement IGSP Interface

Summary

The Gas Saving Pool (GSP) contract does not fully implement all the functions defined in the IGSP interface.

Vulnerability Detail

The IGSP interface includes a getFeeRate() function that is not present in the GSP contract.

Impact

Contracts that interact with the GSP contract through the IGSP interface may experience errors due to the missing implementation of this function.

Code Snippet

https://github.com/sherlock-audit/2023-12-dodo-gsp/blob/main/dodo-gassaving-pool/contracts/GasSavingPool/intf/IGSP.sol#L30

Tool used

Manual Review

Recommendation

Either implement the getFeeRate() function in the GSP contract or remove it from the IGSP interface to avoid potential errors.

nevillehuang commented 9 months ago

Low severity, this mismatch in naming only affects only a view function not integrated in to any other functions, so no impact on funds. In fact, the retrieved variables are public variables that can still be accessed with natural getter functions.