search

sherlock-audit / 2023-12-flatmoney-judging

11 stars 9 forks source link

jennifer37 - Traders may lose funds because of pause. #102

Closed sherlock-admin2 closed 8 months ago

sherlock-admin2 commented 8 months ago

jennifer37

medium

Traders may lose funds because of pause.

Summary

Traders may lose funds because of system paused.

Vulnerability Detail

I believe whenNotPaused is used in some emergency cases. However, traders cannot close their leverage position when executeClose() is paused, which could cause traders lose funds.

Related Code: https://github.com/sherlock-audit/2023-12-flatmoney/blob/main/flatcoin-v1/src/LeverageModule.sol#L255-L260

Impact

Traders may lose funds when executeClose() function is paused.

Code Snippet

    function executeClose(
        address _account,
        address _keeper,
        FlatcoinStructs.Order calldata _order
    ) external whenNotPaused onlyAuthorizedModule returns (int256 settledMargin) {
}

Tool used

Manual Review

Recommendation

Suggest review executeClose(), if possible, leave traders some methods to avoid possible risk.

Duplicate of #80

sherlock-admin commented 8 months ago

1 comment(s) were left on this issue during the judging contest.

takarez commented:

invalid