search

sherlock-audit / 2023-12-flatmoney-judging

11 stars 9 forks source link

dimulski - There is no Chainlink rETH/USD data feed on Base Mainnet #160

Closed sherlock-admin2 closed 6 months ago

sherlock-admin2 commented 7 months ago

dimulski

high

There is no Chainlink rETH/USD data feed on Base Mainnet

Summary

The protocol has specified that they are going to deploy on the BASE network, and they are going to use rETH as a collateral token. In order for the protocol to work it needs to know the price of rETH in USD, but there is no such data feed on Base as of writing this report 04/02/2024. There is a rETH/ETH data feed but the protocol is not configured to convert rETH/ETH price to USD. This makes the whole protocol obsolete.

Vulnerability Detail

When the _getOnchainPrice() gets called the call will revert as there is no such data feed, or if other data feed is used the price will be wrong. It won't matter that there is a Pyth oracle integrated as well.

Impact

The whole protocol won't work.

Code Snippet

Tool used

Manual Review

Recommendation

Modify the OracleModule.sol so it can convert chainlink rETH/ETH prices to USD utilizing ETH/USD data feed.

Duplicate of #90

sherlock-admin commented 6 months ago

2 comment(s) were left on this issue during the judging contest.

0xLogos commented:

medium, protocol simply not working

takarez commented:

invalid: