sherlock-audit / 2023-12-ubiquity-judging

2 stars 2 forks source link

bareli - Update Frequency #188

Closed sherlock-admin2 closed 6 months ago

sherlock-admin2 commented 6 months ago

bareli

medium

Update Frequency

Summary

Update Frequency: The update function's effectiveness depends on how frequently it is called. Infrequent updates can lead to stale prices, which might not accurately reflect the current market conditions.

Vulnerability Detail

function update() external { LibTWAPOracle.update(); }

Impact

Infrequent updates can lead to stale prices, which might not accurately reflect the current market conditions.

Code Snippet

https://github.com/sherlock-audit/2023-12-ubiquity/blob/main/ubiquity-dollar/packages/contracts/src/dollar/facets/TWAPOracleDollar3poolFacet.sol#L33

Tool used

Manual Review

Recommendation

sherlock-admin2 commented 6 months ago

1 comment(s) were left on this issue during the judging contest.

auditsea commented:

Same submitter as #186, seems AI generated

sherlock-admin2 commented 6 months ago

1 comment(s) were left on this issue during the judging contest.

auditsea commented:

Same submitter as #186, seems AI generated

nevillehuang commented 6 months ago

Invalid, update() will be called accordingly when an update is required, as seen in examples here and here