Closed sherlock-admin closed 6 months ago
Lucyan99
medium
Functions not used internally could be marked external.
Found in contracts/JalaMasterRouter.sol Line: 32
function wrapTokensAndaddLiquidity(
Found in contracts/JalaMasterRouter.sol Line: 151
function removeLiquidityETHAndUnwrap(
Found in contracts/JalaRouter02.sol Line: 423
function quote(
Found in contracts/JalaRouter02.sol Line: 431
function getAmountOut(
Found in contracts/JalaRouter02.sol Line: 439
function getAmountIn(
Found in contracts/JalaRouter02.sol Line: 447
function getAmountsOut(
Found in contracts/JalaRouter02.sol Line: 454
function getAmountsIn(
Found in contracts/JalaRouter02.sol Line: 461
function getPairInAdvance(address tokenA, address tokenB) public view virtual override returns (address) {
Found in contracts/utils/ChilizWrappedERC20.sol Line: 29
function underlying() public view returns (IERC20) {
Found in contracts/utils/ChilizWrappedERC20.sol Line: 33
function depositFor(address account, uint256 amount) public virtual returns (bool) {
Found in contracts/utils/ChilizWrappedERC20.sol Line: 45
function withdrawTo(address account, uint256 amount) public virtual returns (bool) {
Found in contracts/utils/ChilizWrappedERC20.sol Line: 62
function getDecimalsOffset() public view returns (uint256) {
Found in contracts/utils/ChilizWrapperFactory.sol Line: 15
function wrap(address account, address underlyingToken, uint256 amount) public returns (address wrappedToken) {
Found in contracts/utils/ChilizWrapperFactory.sol Line: 24
function unwrap(address account, address wrappedToken, uint256 amount) public {
Found in contracts/utils/ChilizWrapperFactory.sol Line: 29
function createWrappedToken(address underlyingToken) public returns (address) {
Found in contracts/utils/ChilizWrapperFactory.sol Line: 48
function wrappedTokenFor(address underlyingToken) public view returns (address wrappedToken) {
Found in contracts/utils/ChilizWrapperFactory.sol Line: 65
function getUnderlyingToWrapped(address underlying) public view returns (address) {
Invalid, this is at most a gas optimization finding not valid based on sherlock rules. Additionally, sherlock only accepts medium/high severity issues.
Lucyan99
medium
NC-2: Functions not used internally could be marked external
Summary
Functions not used internally could be marked external.
Code Snippet
Found in contracts/JalaMasterRouter.sol Line: 32
Found in contracts/JalaMasterRouter.sol Line: 151
Found in contracts/JalaRouter02.sol Line: 423
Found in contracts/JalaRouter02.sol Line: 431
Found in contracts/JalaRouter02.sol Line: 439
Found in contracts/JalaRouter02.sol Line: 447
Found in contracts/JalaRouter02.sol Line: 454
Found in contracts/JalaRouter02.sol Line: 461
Found in contracts/utils/ChilizWrappedERC20.sol Line: 29
Found in contracts/utils/ChilizWrappedERC20.sol Line: 33
Found in contracts/utils/ChilizWrappedERC20.sol Line: 45
Found in contracts/utils/ChilizWrappedERC20.sol Line: 62
Found in contracts/utils/ChilizWrapperFactory.sol Line: 15
Found in contracts/utils/ChilizWrapperFactory.sol Line: 24
Found in contracts/utils/ChilizWrapperFactory.sol Line: 29
Found in contracts/utils/ChilizWrapperFactory.sol Line: 48
Found in contracts/utils/ChilizWrapperFactory.sol Line: 65