thisvishalsingh - thisvishalsingh - High level access functions can create points of failure

[sherlock-admin]

thisvishalsingh

medium

thisvishalsingh - High level access functions can create points of failure

thisvishalsingh

High level access functions can create points of failure

medium

Summary

High-level access functions in , especially those with administrative privileges, can lead to points of failure due to their potential for misuse and unauthorized access. These functions, if compromised, can allow attackers to escalate privileges, leading to unauthorized control or access to sensitive data and functionalities. Insecure direct object references, where user inputs aren't properly validated, can exacerbate this risk, allowing attackers to manipulate the system. Ensuring robust access control and validation mechanisms is crucial to mitigate these vulnerabilities

Vulnerability Detail

• https://github.com/sherlock-audit/2024-02-jala-swap/blob/main/jalaswap-dex-contract/contracts/JalaFactory.sol#L60
• https://github.com/sherlock-audit/2024-02-jala-swap/blob/main/jalaswap-dex-contract/contracts/JalaFactory.sol#L65
• https://github.com/sherlock-audit/2024-02-jala-swap/blob/main/jalaswap-dex-contract/contracts/JalaFactory.sol#L71
• https://github.com/sherlock-audit/2024-02-jala-swap/blob/main/jalaswap-dex-contract/contracts/JalaFactory.sol#L76
• https://github.com/sherlock-audit/2024-02-jala-swap/blob/main/jalaswap-dex-contract/contracts/JalaFactory.sol#L81

Impact

if compromised, can allow attackers to escalate privileges, leading to unauthorized control or access to sensitive data and functionalities.

Tool used

Manual Review

Recommendation

Ensuring robust access control and validation mechanisms is crucial to mitigate these vulnerabilities

[nevillehuang]

Invalid, as noted in contest details, admins are trusted entities trusted to not be malicious