sherlock-audit / 2024-02-rubicon-finance-judging

5 stars 3 forks source link

jennifer37 - Trader's order may not be completed finished because of fillThreshold. #56

Closed sherlock-admin closed 7 months ago

sherlock-admin commented 7 months ago

jennifer37

medium

Trader's order may not be completed finished because of fillThreshold.

Summary

Trader's order may not be completed finished because of fillThreshold.

Vulnerability Detail

Trader Alice submits one order.
Filler Bob takes the order and execute partial order.
If the percentage of left order is less than fillThreshold, left part of this order cannot be executed.

Impact

Trader's order cannot be completely executed.

Code Snippet

https://github.com/sherlock-audit/2024-02-rubicon-finance/blob/main/gladius-contracts-internal/src/lib/PartialFillLib.sol#L119-L130

Tool used

Manual Review

Recommendation

Make sure left part of order is not less than fillThreshold.

sherlock-admin commented 7 months ago

1 comment(s) were left on this issue during the judging contest.

0xAadi commented:

Invalid: Lacks details