bareli - Some ERC20 can revert on a zero value transfer

[sherlock-admin4]

bareli

medium

Some ERC20 can revert on a zero value transfer

Summary

Not all ERC20 implementations are totally compliant, and some (e.g LEND) may fail while transfering a zero amount.

Vulnerability Detail

function emergencySaveTokens(address _token, uint256 _amount) external onlyOwner { if (_token == address(0)) { (bool sent,) = msg.sender.call{value: _amount}(""); if (!sent) revert Failed(); emit EmergencySaved(_token, _amount, true); } else { @> IERC20(_token).safeTransfer(msg.sender, _amount); emit EmergencySaved(_token, _amount, false); } }

Impact

Not all ERC20 implementations are totally compliant, and some (e.g LEND) may fail while transfering a zero amount.

Code Snippet

https://github.com/sherlock-audit/2024-02-tapioca/blob/main/TapiocaZ/contracts/Balancer.sol#L212

Tool used

Manual Review

Recommendation

function emergencySaveTokens(address _token, uint256 _amount) external onlyOwner { @>if (amount>0) { if (_token == address(0)) { (bool sent,) = msg.sender.call{value: _amount}(""); if (!sent) revert Failed(); emit EmergencySaved(_token, _amount, true); } else { IERC20(_token).safeTransfer(msg.sender, _amount); emit EmergencySaved(_token, _amount, false); } } }

[maarcweiss]

Invalid

[nevillehuang]

Invalid, such tokens were not mentioned to be supported in the contest details