search

sherlock-audit / 2024-03-arrakis-judging

2 stars 2 forks source link

NoOne - Library function isn't `internal` or `private` #12

Closed sherlock-admin4 closed 3 months ago

sherlock-admin4 commented 3 months ago

NoOne

medium

Library function isn't internal or private

Summary

Vulnerability Detail

In a library, using an external or public visibility means that we won't be going through the library with a DELEGATECALL but with a CALL. This changes the context and should be done carefully.

Impact

Code Snippet

function getReservesAtPrice

Tool used

Manual Review

Recommendation

Change it to internal or private