sherlock-audit / 2024-03-arrakis-judging

0 stars 0 forks source link

0xrobsol - Cooldown Period Management in _updateParamsChecks Function #83

Closed sherlock-admin3 closed 1 month ago

sherlock-admin3 commented 1 month ago

0xrobsol

high

Cooldown Period Management in _updateParamsChecks Function

Summary

The _updateParamsChecks function within the smart contract includes a check to ensure that a cooldown period is set. However, there are concerns regarding how the cooldown period is reset.

Vulnerability Detail

The function currently does not include a mechanism to reset the cooldown period once it has finished. This omission could prevent subsequent updates from occurring as intended.

Impact

Without a mechanism to reset the cooldown period, the contract might enter a state where no further updates can be made, effectively halting operations that depend on timely updates.

Code Snippet

https://github.com/sherlock-audit/2024-03-arrakis/blob/main/arrakis-modular/src/ArrakisStandardManager.sol#L653-L656

Tool used

Manual Review

Recommendation

Ensure there is a mechanism within the contract to reset the cooldown period after it has finished. This could involve updating the lastrebalanceupdate at the appropriate times to reflect the most recent valid rebalance operation.

cu5t0mPeo commented 1 month ago

information, invalid